remove manual heap profiling from ghcide #3168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
approved these changes
Sep 15, 2022
michaelpj
approved these changes
Sep 15, 2022
Oops. I have been using the VSCode GitHub extension to create PRs and maybe it automatically reuses prior titles |
pepeiborra
changed the title
Just use 9.2 or higher to analyse memory, there is no reason to support analysis in older versions |
|
Build failures on 9.4 |
pepeiborra
force-pushed
the
heapsize-clean
branch
from
2c0b5f9 to
7f33b41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The memory profiling scheme was added by @mpardalos. It works by stopping the world and traversing the heap using the
heapsizepackage, but it breaks if a GC starts halfway, leading to a segfault.Nowadays we have a better tool for this sort of analysis, ghc-debug, which snapshots the heap and performs the analysis offline.