HLS for the new generated LSP 2 release #3621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And bump hls version to keep cabal sane
Readd the HasTracing constraint
Now tracking my fork of the new lsp release which dumps TResponseError
|
@everyone This builds and all the tests pass. Would love some more eyes on the changes though, to make sure I didn't let anything nasty slip through. |
michaelpj
approved these changes
Jun 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am going through the codebase to update it to @michaelpj 's upcoming LSP 2 release. So far the only part that compiles is hls-plugin-api. I am currently working on ghcide, which should be the last hard part of this change. The new LSP release is generated, which means there are a lot of changes, hence this PR will probably end up touching pretty much every part of the project.
If you would like to start reviewing this work, you should start with hls-plugin-api. Again it is the only part that compiles, and other parts will be subject to significant change.