Fixes to persistVirtualFile #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 26, 2019
alanz
reviewed
Nov 26, 2019
mpickering
force-pushed
the
wip/persist-virtual-file
branch
from
e596aac to
d911fe3
Compare
lukel97
reviewed
Nov 27, 2019
lukel97
reviewed
Nov 27, 2019
| @@ -17,6 +17,9 @@ module Language.Haskell.LSP.VFS | |||
| ( | |||
| VFS(..) | |||
There was a problem hiding this comment.
Should we hide the fields of the VFS record?
There was a problem hiding this comment.
My opinion is no, it would be very annoying for someone if they had to add a missing function themselves.
alanz
reviewed
Nov 27, 2019
The old version field corresponds to an LSP notion of versioning which resets of saves. The new version field increases monotonically and is used to seed the temporary file names.
fendor
force-pushed
the
wip/persist-virtual-file
branch
from
2d99c75 to
b4ffb64
Compare
alanz
approved these changes
Dec 13, 2019
lukel97
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybewhen the file does not exist in the VFS