Update SignatureHelp types #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 tasks
|
Ah, |
|
Doh, it needs a support capability too. Let me look at that... |
michaelpj
force-pushed
the
signaturehelp-markup
branch
from
59033db to
f203bf5
Compare
michaelpj
force-pushed
the
signaturehelp-markup
branch
from
8280472 to
0ba0f4c
Compare
|
Oops I did label offset support too 😅 |
|
Failure seems spurious. |
|
rerunning ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now supports
MarkupContent.I also added the
activeParameterfield toSignatureInformation, whichappears in the spec but not in our implementation.