Fix WorkspaceSemanticTokensRefresh type to be FromServer, not FromClient #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
approved these changes
Jul 1, 2022
|
Can you click the "allow edits from maintainers" checkbox? I can't merge master into your branch and neither can mergify. BTW I've made a lot of progress on #421 and I'm hoping to have something usable before too long :) |
thomasjm
force-pushed
the
fix-workspace-semantic-tokens-refresh
branch
from
2139db9 to
007dbdb
Compare
|
I don't seem to have that checkbox? Just rebased onto master. |
|
Thanks @michaelpj -- Great news about #421 by the way, can't wait to see it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is currently miscategorized as a
Method FromClient Request, but it should be aMethod FromServer Request.See here:
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#semanticTokens_refreshRequest