Separate lens module, Have ResponseErrors also take LSPResponseErrors, and standardize SemanticToken fields #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The last commit was to unify both the generated and custom lens classes, so now there are no namespace clashes between them and they are all exported from the same module. |
michaelpj
reviewed
Jun 6, 2023
lsp-types/src/Language/LSP/Protocol/Types/SemanticTokensLens.hs
Outdated
Show resolved
Hide resolved
lsp-types/src/Language/LSP/Protocol/Message/RegistrationLens.hs
Outdated
Show resolved
Hide resolved
| @@ -105,6 +105,7 @@ test-suite tests | |||
| , lsp ^>=2.0 | |||
| , lsp-test | |||
| , mtl <2.4 | |||
| , parser-combinators | |||
There was a problem hiding this comment.
I got an error from hls that the package was hidden and that I needed to depend on it. There is I believe some related import, but it was weird that it wasn't a problem before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes three separate changes. The first is to separate the lens module into a separate exported module. Currently, this only includes the lens for the generated modules. The second change is to allow (T)ResponseErrors to take both a ResponseError and a LSPResponseError. To do this I used custom fromJSON code that will first convert the JSON to a ResponseError and then convert any CustomResponseError results to corresponding LSPResponseError types. Finally, I standardized the fields for SemanticToken.