Skip to content

Update to support GHC 9.6 #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 24, 2023
Merged

Update to support GHC 9.6 #459

merged 8 commits into from
Jun 24, 2023

Conversation

michaelpj
Copy link
Contributor

Fixes #458

@michaelpj
Copy link
Contributor Author

Hmm, looks like the latest ghc-lib-parser doesn't support 9.0. I'm not sure what to do about that: AFAICT that's their intended support policy, and to do anything else we'd need to add a bunch of CPP, which is exactly what we're avoiding with ghc-lib-parser. So maybe it's just time to drop 9.0?

@michaelpj
Copy link
Contributor Author

I added 9.6 to the workflow and removed 9.0, but it probably won't run since my PR is from a fork.

@michaelpj michaelpj mentioned this pull request Jun 24, 2023
Closed
jaspervdj
jaspervdj approved these changes Jun 24, 2023
View reviewed changes
Copy link
Member

@jaspervdj jaspervdj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I was about to bump optparse-applicative in another PR, thanks for taking care of that as well!

@michaelpj
Copy link
Contributor Author

Yeah, I'm just trying to make stack happy...

@michaelpj
Copy link
Contributor Author

Okay, it's all green!

@jaspervdj jaspervdj merged commit 4f08b1a into haskell:main Jun 24, 2023
@jaspervdj
Copy link
Member

Thanks a lot!

@michaelpj
Copy link
Contributor Author

It would be great to get a release, then we can get this supported in HLS.

@jaspervdj
Copy link
Member

Released as v0.14.5.0

@michaelpj
Copy link
Contributor Author

Thanks, I've made a PR to enable it in HLS :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaspervdj jaspervdj jaspervdj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GHC 9.6 support
2 participants
@michaelpj @jaspervdj