Synchronize ByteString and String modules #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasufell
commented
Jul 16, 2022
hasufell
force-pushed
the
sync-bs
branch
2 times, most recently
from
4550490 to
707737c
Compare
hasufell
commented
Jul 17, 2022
hs-viktor
reviewed
Jul 17, 2022
System/Posix/Env/ByteString.hsc
Outdated
| #endif | ||
|
|
||
| -- |'putEnv' function takes an argument of the form @name=value@ | ||
| -- and is equivalent to @setEnv(key,value,True{-overwrite-})@. | ||
|
|
||
| putEnv :: ByteString {- ^ "key=value" -} -> IO () | ||
| putEnv keyvalue = B.useAsCString keyvalue $ \s -> | ||
| throwErrnoIfMinus1_ "putenv" (c_putenv s) | ||
| putEnv (PS fp _ l) = withForeignPtr fp $ \p -> do |
There was a problem hiding this comment.
Is this code really going to be built against ancient bytestring versions that have PS instead of BS? And if it were, it would be very wrong to ignore the offset. Use BS instead.
There was a problem hiding this comment.
Using BS would require build-depends: bytestring >= 0.11. That's acceptable, but it's easy to be more conservative with
putEnv (PS fp o l) = withForeignPtr fp $ \p -> do ... (p `plusPtr` o)There was a problem hiding this comment.
Sorry... it was almost 2 am at night.
And fix free-bug in 'putEnv'. Fixes haskell#68
hasufell
commented
Jul 17, 2022
Comment on lines
+18
to
+32
| test :: TestTree | ||
| test = testCase "putEnv" $ do | ||
| performMinorGC | ||
| env <- System.Posix.Env.ByteString.getEnv (fromString "foo") | ||
| performMinorGC | ||
| print env | ||
| env <- System.Posix.Env.ByteString.getEnv (fromString "foo") | ||
| performMinorGC | ||
| print env | ||
| env <- System.Posix.Env.ByteString.getEnv (fromString "foo") | ||
| performMinorGC | ||
| print env | ||
| env <- System.Posix.Env.ByteString.getEnv (fromString "foo") | ||
| print env | ||
| env @?= Just (fromString "bar") |
There was a problem hiding this comment.
The failure is a little hard to trigger... but this worked for me and the prints are necessary.
Bodigrim
approved these changes
Jul 17, 2022
This was referenced Jul 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix free-bug in 'putEnv'. Fixes #68