Clarify error message for createLink, createSymbolicLink and rename #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
POSIX's ENOENT error doesn't specify if the problem was with source or destination path. Throw error mentioning both paths instead of only first one. Fixes #60
| @@ -253,7 +253,8 @@ createSymbolicLink :: FilePath -> FilePath -> IO () | |||
| createSymbolicLink file1 file2 = | |||
| withFilePath file1 $ \s1 -> | |||
| withFilePath file2 $ \s2 -> | |||
| throwErrnoPathIfMinus1_ "createSymbolicLink" file1 (c_symlink s1 s2) | |||
| throwErrnoIfMinus1_ ("createSymbolicLink "++file1++" to "++file2) | |||
There was a problem hiding this comment.
For a link (symbolic or hard) this message may be confusing. When we say ln s1 s2, we are creating s2 which points to s1, is that a s1 to s2 link or s2 to s1? The unix manual for symlink uses the terms linkpath (s2) and target (s1), maybe we can use the same terminology in the error message here. That way it will also be easy to correlate the error message with syscall manual when debugging.
|
This is still open after >2 years, can it be updated and merged? It's still an issue. |
luispedro
added a commit
to luispedro/unix
that referenced
this pull request
Nov 11, 2018
Per the comments on PR haskell#65, it should be unambiguous.
luispedro
added a commit
to luispedro/unix
that referenced
this pull request
Feb 16, 2021
Per the comments on PR haskell#65, it should be unambiguous.
luispedro
added a commit
to luispedro/unix
that referenced
this pull request
Feb 20, 2021
Per the comments on PR haskell#65, it should be unambiguous.
luispedro
added a commit
to luispedro/unix
that referenced
this pull request
Feb 22, 2021
Per the comments on PR haskell#65, it should be unambiguous.
hs-viktor
pushed a commit
that referenced
this pull request
Feb 24, 2021
Per the comments on PR #65, it should be unambiguous.
hasufell
pushed a commit
to hasufell/unix
that referenced
this pull request
Jul 19, 2022
Per the comments on PR haskell#65, it should be unambiguous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POSIX's ENOENT error doesn't specify if the problem was with source or
destination path. Throw error mentioning both paths instead of only
first one.
Fixes #60