Skip to content

DEV-667: get it working so we can stage an item #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 29, 2023
Merged

DEV-667: get it working so we can stage an item #1

merged 6 commits into from
Mar 29, 2023

Conversation

aelkiss
Copy link
Member

@aelkiss aelkiss commented Mar 22, 2023

No description provided.

aelkiss added 3 commits March 22, 2023 12:49
@aelkiss
Tests pass & are consistent w/ README
3e58c4d 
* use Dir.mktmpdir to isolate & clean up each test
* make namespace creation tests pass & be consistent w/ README
@aelkiss
Add standardrb
8a75aea
@aelkiss
Run rspec and standardrb on push
c2729a5
@aelkiss aelkiss requested a review from billdueber March 22, 2023 16:55
@aelkiss
Copy link
Member Author

aelkiss commented Mar 22, 2023

We should probably also rename master to main while we're in here.

@aelkiss aelkiss mentioned this pull request Mar 23, 2023
Closed
@aelkiss
Ensure prefix is set correctly
b03be89 
* Always pass prefix argument to pairtree
* Defer to underlying creation in pairtree gem
@aelkiss aelkiss force-pushed the DEV-667-stage-item branch from 7021c21 to b03be89 Compare March 27, 2023 20:38
@aelkiss
Copy link
Member Author

aelkiss commented Mar 28, 2023

The underlying rpairtree gem was not compatible with ruby 3.2 (it relied on the deprecated File.exists?). I got ownership on the original https://github.com/ruby-microservices/pairtree and gem; once we get ruby-microservices/pairtree#5 merged I'll release a new version of the gem and update this to use that.

@aelkiss
Copy link
Member Author

aelkiss commented Mar 29, 2023

I will update this to use the new upstream pairtree gem but @billdueber if you have a chance to look at this I'd appreciate it, or @moseshll if you have time

@billdueber
Copy link
Collaborator

Is this one ready to go now? Code is all clean and obvious, and I'm happy to merge if you think you're done with the whole upstream song-and-dance.

@aelkiss
Copy link
Member Author

aelkiss commented Mar 29, 2023

Yes, this is ready to go. I'm not sure why the checks aren't showing up as completed, but it looks like they passed?? I'll go ahead and merge imminently.

@aelkiss
Copy link
Member Author

aelkiss commented Mar 29, 2023

According to https://www.githubstatus.com/ github actions is having some issue. I ran the matrixed tests locally with https://github.com/nektos/act and all 4 passed, so I'm going to go ahead and merge.

@aelkiss aelkiss merged commit a8620c4 into master Mar 29, 2023
@aelkiss aelkiss deleted the DEV-667-stage-item branch March 29, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billdueber billdueber Awaiting requested review from billdueber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aelkiss @billdueber