Correção de dupla geração de hash ao cadastrar novo usuário #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Open
Closed
This was referenced Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O método que gera hash da senha do usuário era chamado duas vezes ao cadastrar um novo usuário. Fazia com que fosse gerado um "hash da hash", tornando a senha do usuário inválida. Notei esse problema quando cadastrei um usuário novo e tentei fazer login com ele.
Aproveitei e corrigi um typo no admin-users.php, que por coincidência é em uma das chamadas duplicadas do método.
Estou fazendo esse pull request pois algum aluno pode clonar o repo, encontrar esse bug e não saber o que fazer.