feat: add AZKV_AUTH env var for azure key vault #711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natescherer
requested review from
itscaro,
mumoshu,
xiaomudk and
yxxhero
as code owners
|
This also fixes #408 |
Signed-off-by: Nate Scherer <[email protected]>
Signed-off-by: Nate Scherer <[email protected]>
Signed-off-by: Nate Scherer <[email protected]>
Signed-off-by: Nate Scherer <[email protected]>
Signed-off-by: Nate Scherer <[email protected]>
natescherer
force-pushed
the
azure-key-vault-auth
branch
from
a56d0a1 to
e4ffdcb
Compare
Done! |
yxxhero
reviewed
Jul 13, 2025
| } | ||
| chain = append(chain, cred) | ||
| default: | ||
| panic("Environment variable 'AZKV_AUTH' is set to an unsupported value!") |
There was a problem hiding this comment.
My assumption was we should cause the entire rendering to fail immediately if someone provides a malformed variable value as vals (and any tools calling it) won't produce the desired output if the auth type can't be determined.
If you disagree, though, I'm happy to refactor to throw an error.
There was a problem hiding this comment.
@natescherer we should not use panic as mush as we can.
There was a problem hiding this comment.
Okay, I refactored, built and tested, let me know what you think.
natescherer
force-pushed
the
azure-key-vault-auth
branch
from
208f6ea to
545e58b
Compare
Signed-off-by: Nate Scherer <[email protected]>
natescherer
force-pushed
the
azure-key-vault-auth
branch
from
545e58b to
1700ba2
Compare
yxxhero
approved these changes
Jul 14, 2025
CorentinPtrl
pushed a commit
to CorentinPtrl/vals
that referenced
this pull request
Oct 8, 2025
* feat: add AZKV_AUTH env var for azure key vault Signed-off-by: Nate Scherer <[email protected]> * fix: switch to using NewChainedTokenCredential Signed-off-by: Nate Scherer <[email protected]> * fix: append to slices Signed-off-by: Nate Scherer <[email protected]> * fix: properly append to slices Signed-off-by: Nate Scherer <[email protected]> * docs: update azure key vault docs Signed-off-by: Nate Scherer <[email protected]> * refactor: return error instead of panicking Signed-off-by: Nate Scherer <[email protected]> --------- Signed-off-by: Nate Scherer <[email protected]> Signed-off-by: CorentinPtrl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the confusion on opening this PR earlier than I intended to.
This PR adds support for being able to choose which authentication method you use for Azure Key Vault, as well as correcting the documentation which incorrectly described how the azidentity Go module currently handled authentication.
Please let me know if you want me to update or change anything!