added guid/luid translations for windows #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpotter2
reviewed
Jul 16, 2019
|
|
||
| /* testing of nhGetInterfaceNameFromGuid indicates the unpublished API function expects the 3rd parameter | ||
| * to be the available space in bytes (as compared to wchar's) available in the second parameter buffer | ||
| * to receive the friendly name (in unicode format) including the space for the nul termination.*/ |
There was a problem hiding this comment.
Thats some very scary stuff 😄 (understand: this PR was merged WAYYYY too quickly)
Not only does this PR breaks backward compatibility (it requires the name rather than the UUID. This will break basically everything), and uses a name that may suffer from duplication (yes, you can change an adapter's name), but it also uses an undeclared function, that could disappear at anytime.
I know the intent is good, but there is a reason to use very "unfriendly" GUIDs: they are unique ! That's like, the whole point of it !
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PCAP on Windows needs GUID's (names of devices in format
\Device\NPF_{AAAAAAAA-AAAA-AAAA-AAAA-AAAAAAAAAAAA}, and this is whatfindalldevsreturns and whatopen_liveexpects.The matching readable names (like
Local Area ConnectionandEthernet) are hard to find, so I added this functionality to make it transparent to the user.Basically, I made
findalldevsreturn the readable names, andopen_liveexpect them.