Skip to content

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Oct 3, 2024

Closes #552

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Oct 3, 2024

🦋 Changeset detected

Latest commit: dc696e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mrlubos mrlubos marked this pull request as ready for review October 3, 2024 08:05
Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 8:06am

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.02%. Comparing base (baaf986) to head (dc696e0).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../v3/parser/getRequiredPropertiesFromComposition.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1113      +/-   ##
==========================================
- Coverage   81.10%   81.02%   -0.09%     
==========================================
  Files         104      104              
  Lines       11591    11597       +6     
  Branches     1238     1237       -1     
==========================================
- Hits         9401     9396       -5     
- Misses       2187     2198      +11     
  Partials        3        3              
Flag Coverage Δ
unittests 81.02% <87.50%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

pkg-pr-new bot commented Oct 3, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@hey-api/client-axios@1113
pnpm add https://pkg.pr.new/@hey-api/client-fetch@1113
pnpm add https://pkg.pr.new/@hey-api/openapi-ts@1113

commit: dc696e0

@mrlubos mrlubos merged commit e7e69e1 into main Oct 3, 2024
16 of 17 checks passed
@mrlubos mrlubos deleted the fix/maximum-call-stack-exceeded branch October 3, 2024 08:20
@github-actions github-actions bot mentioned this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximum call stack size exceeded when processing some open api spec
1 participant