Skip to content

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Oct 3, 2024

Closes #1112

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Oct 3, 2024

🦋 Changeset detected

Latest commit: e694787

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mrlubos mrlubos marked this pull request as ready for review October 3, 2024 11:05
Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 11:12am

Copy link

pkg-pr-new bot commented Oct 3, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@hey-api/client-axios@1115
pnpm add https://pkg.pr.new/@hey-api/client-fetch@1115
pnpm add https://pkg.pr.new/@hey-api/openapi-ts@1115

commit: e694787

@mrlubos mrlubos merged commit c68e83b into main Oct 3, 2024
15 of 17 checks passed
@mrlubos mrlubos deleted the fix/abstract-infinite-params branch October 3, 2024 11:55
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 7.10900% with 196 lines in your changes missing coverage. Please review.

Project coverage is 80.65%. Comparing base (e7e69e1) to head (e694787).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...napi-ts/src/plugins/@tanstack/query-core/plugin.ts 1.51% 195 Missing ⚠️
packages/openapi-ts/src/compiler/return.ts 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1115      +/-   ##
==========================================
- Coverage   81.02%   80.65%   -0.37%     
==========================================
  Files         104      104              
  Lines       11597    11663      +66     
  Branches     1237     1238       +1     
==========================================
+ Hits         9396     9407      +11     
- Misses       2198     2253      +55     
  Partials        3        3              
Flag Coverage Δ
unittests 80.65% <7.10%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot mentioned this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abstract page params logic in TanStack Query plugin
1 participant