You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an option asInstance that makes the sdk class instantiable. Specifically:
Methods are instance methods instead of static
The sdk takes a client as a parameter in the constructor, and sdk methods use the instance of the client.
This allows creating multiple instances of the sdk that work independently. My use case is using a client during server side rendering where each sdk instance is authenticated with the end-user's auth token which has limited permissions (as opposed to using a single client with admin permissions).
This adds an option asInstance that makes the sdk class instantiable.
Specifically:
1. Methods are instance methods instead of static
2. The sdk takes a client as a parameter in the constructor, and sdk
methods use the instance of the client.
This allows creating multiple instances of the sdk that work
independently. My use case is using a client during server side
rendering where each sdk instance is authenticated with the end-user's
auth token which has limited permissions (as opposed to using a single
client with admin permissions).
Contributes hey-api#671
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
@ibash you've achieved a surprising amount with so few lines of code! I don't have it exactly implemented as you did in this pull request, but I'll push the initial instances release today. If you're still using this package, your feedback would be appreciated!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an option asInstance that makes the sdk class instantiable. Specifically:
This allows creating multiple instances of the sdk that work independently. My use case is using a client during server side rendering where each sdk instance is authenticated with the end-user's auth token which has limited permissions (as opposed to using a single client with admin permissions).
Contributes #671
I could use some guidance on how to add a snapshot test for this.