Skip to content

Conversation

seriouslag
Copy link
Contributor

@seriouslag seriouslag commented Apr 11, 2025

Added exports for getSpec, initConfigs, and parseOpenApiSpec to the new exported internal file for improved accessibility of these functions across internal packages

These functions are helpful for custom clients and plugins.

Marked the exported functions as @internal, and I put them in a new export path

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Apr 11, 2025

🦋 Changeset detected

Latest commit: d4df550

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2025 10:02pm

@mrlubos
Copy link
Member

mrlubos commented Apr 11, 2025

Why? 🤠

Copy link

pkg-pr-new bot commented Apr 11, 2025

Open in StackBlitz

@hey-api/client-axios

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-axios@1934

@hey-api/client-fetch

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-fetch@1934

@hey-api/client-next

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-next@1934

@hey-api/client-nuxt

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-nuxt@1934

@hey-api/nuxt

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@1934

@hey-api/openapi-ts

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@1934

@hey-api/vite-plugin

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@1934

commit: d4df550

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.03%. Comparing base (729488e) to head (d4df550).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1934      +/-   ##
==========================================
+ Coverage   24.14%   29.03%   +4.88%     
==========================================
  Files         193      194       +1     
  Lines       26861    26871      +10     
  Branches      787      724      -63     
==========================================
+ Hits         6486     7802    +1316     
+ Misses      20300    19063    -1237     
+ Partials       75        6      -69     
Flag Coverage Δ
unittests 29.03% <100.00%> (+4.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@seriouslag
Copy link
Contributor Author

seriouslag commented Apr 11, 2025

Why? 🤠

Exporting these functions to be able to use them in other packages, I will be using these in the NX plugin once I figure out the test issues. This change deserves its own PR anyways.

Breaking the NX plugin PR in smaller PRs.

@seriouslag seriouslag force-pushed the feat/add-shared-exports branch from 9914ec8 to 0935f86 Compare April 13, 2025 19:41
@seriouslag seriouslag force-pushed the feat/add-shared-exports branch from 0935f86 to 1d9d6b0 Compare April 13, 2025 19:45
@seriouslag seriouslag changed the title feat(openapi-ts): export additional functions from index.ts feat(openapi-ts): export additional functions from openapi-ts Apr 13, 2025
Added exports for getSpec, initConfigs, and parseOpenApiSpec to a new internal export file for improved accessibility of these functions for non public consumption.

Marked these functions as internal as they are not to be used publicly
@mrlubos mrlubos merged commit cd5d653 into hey-api:main Apr 13, 2025
17 checks passed
@github-actions github-actions bot mentioned this pull request Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants