Skip to content

Conversation

carson2222
Copy link
Contributor

@carson2222 carson2222 commented Sep 2, 2025

It will fail for now, waiting for hey-api/json-schema-ref-parser#13 to be merged.
fix #2550
fix #2551

This was added to @hey-api/json-schema-ref-parser 1.0.8 but I'm moving it directly to openapi-ts
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Sep 2, 2025

⚠️ No Changeset found

Latest commit: 14af188

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hey-api-docs Ready Ready Preview Comment Sep 3, 2025 11:31am

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. bug 🔥 Something isn't working labels Sep 2, 2025
Copy link

pkg-pr-new bot commented Sep 3, 2025

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/codegen-core@2583
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2583
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2583
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2583

commit: 14af188

Copy link

codecov bot commented Sep 3, 2025

Codecov Report

❌ Patch coverage is 0% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 23.59%. Comparing base (a312623) to head (14af188).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ages/openapi-ts/src/openApi/2.0.x/parser/schema.ts 0.00% 15 Missing ⚠️
...ages/openapi-ts/src/openApi/3.0.x/parser/schema.ts 0.00% 15 Missing ⚠️
...ages/openapi-ts/src/openApi/3.1.x/parser/schema.ts 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2583      +/-   ##
==========================================
- Coverage   23.61%   23.59%   -0.03%     
==========================================
  Files         363      363              
  Lines       36504    36549      +45     
  Branches     1562     1562              
==========================================
  Hits         8622     8622              
- Misses      27869    27914      +45     
  Partials       13       13              
Flag Coverage Δ
unittests 23.59% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@carson2222 carson2222 requested review from mrlubos and removed request for mrlubos September 3, 2025 12:19
@carson2222 carson2222 merged commit 38a353e into main Sep 3, 2025
12 of 14 checks passed
@carson2222 carson2222 deleted the fix(parser)--improve-$ref-handling branch September 3, 2025 16:27
@carson2222 carson2222 restored the fix(parser)--improve-$ref-handling branch September 4, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🔥 Something isn't working size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using the same external ref multiple times generates types.gen.ts with invalid typescript Failed types generation with refs

1 participant