Skip to content
This repository was archived by the owner on Dec 1, 2024. It is now read-only.

Add Github Actions to update schema #462

Merged
merged 4 commits into from
Jun 1, 2022

Conversation

Atry
Copy link
Contributor

@Atry Atry commented May 31, 2022

Changes in this PR

  • The job update-schema is added to Github Actions.
    • It is executed everyday to create pull requests to update schema if it the schema changes. One for breaking change and one for backward compatible change. The maintainer can review the PRs to merge one of them. For example: Update schema Atry/hhast#3 and Update schema to a backward incompatible version Atry/hhast#4
    • It is also executed on pull request and will add suggestions to the pull request if it detect the schema needs regeneration.
  • src/__Private/codegen/CodegenLastestBreakingVersion.hack is a code generator to generate codegen-no-rebuild/latest_breaking_version.hack, which includes the version number of latest breaking change on AST.
  • src/__Private/is_compatible_schema_version.hack is updated to use codegen-no-rebuild/latest_breaking_version.hack to determine whether a schema version is compatible, so we don't have to manually edit the file any more until the 100th century.
  • The job determine-latest-breaking-hhvm-version is added to Github Actions to calculate the oldest supported HHVM version so we don't have to manually update .github/workflows/build-and-test.yml any more.
  • The job update-schema is also executed when pushing a commit to any branch in either this repository or a forked repository. When a commit is pushed and the schema change is detected, the pull requests in that repository are created against that branch. For example, 4d3644c and 4bb47c4 in this PR are created by dogfooding PRs from Update schema to a backward incompatible version Atry/hhast#4 .

@Atry Atry force-pushed the github-actions-update-schema branch 8 times, most recently from e73febb to e9cd287 Compare June 1, 2022 02:33
@Atry Atry force-pushed the github-actions-update-schema branch from e9cd287 to 4bb47c4 Compare June 1, 2022 02:36
@Atry Atry marked this pull request as ready for review June 1, 2022 02:50
@Atry Atry requested review from alexeyt and lexidor June 1, 2022 03:08
@Atry Atry requested a review from lexidor June 1, 2022 19:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants