Skip to content

HHH-19584 add @CurrentTimestamp(allowMutation) #10462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gavinking
Copy link
Member

@gavinking gavinking commented Jul 2, 2025

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-19584

Comment on lines +265 to +269
@Override
public boolean allowMutation() {
return allowMutation;
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yrodiere This is the only significant thing here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, but should we merge this immediately, or do you want someone to have a look at the "manually set the value for inserts" case too?
Asking because that might change the exposed API, if we decide its' better (simpler) to expose a single allowOverride() attribute controlling whether people can manually set the value for both inserts and updates.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, but should we merge this immediately, or do you want someone to have a look at the "manually set the value for inserts" case too?

Well, nobody actually asked for that yet. (Except you 😉)

Asking because that might change the exposed API, if we decide its' better (simpler) to expose a single allowOverride() attribute controlling whether people can manually set the value for both inserts and updates.

It's not linked directly to inserts vs updates, it depends on whether the client can override generation. So I think it's two different things.

All that said, we can't merge this without a test.

@gavinking gavinking force-pushed the current-timestamp-allow-mutation branch from 755f3ee to 94349ce Compare July 2, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants