x: Added phpstan rules to verify access between layers in hexagonal arch… #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krchiper
changed the title
frederikhs
approved these changes
Apr 28, 2025
| @@ -41,6 +45,11 @@ | |||
| "Hiper\\PHPStan\\": "src" | |||
| } | |||
| }, | |||
| "autoload-dev": { | |||
| "psr-4": { | |||
| "Test\\": "tests/test-fixtures" | |||
There was a problem hiding this comment.
eneste jeg tænker er om namespace ikke skal være Test\Fixtures\DDD så de var adskilt fra class const reglens fixtures. I samme omfang kunne de også flyttes til en undermappe under test-fixtures (men de har ikke namespace så behøver ikke namespace ændring
Comment on lines
+15
to
18
| { | ||
| "name": "Kim Winther Carlsen", | ||
| "homepage": "https://github.com/krchiper" | ||
| } |
There was a problem hiding this comment.
husk også at tilføje dig selv til CODEOWNERS filen @ .github/CODEOWNERS. Med stjerne på repo og evt med overskrivning på src/Rules/DomainDrivenDesignRule.php samt fixtures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify access rules from Hexagonal architecture, that dictates only outer layers may depend on inner layers
Infrastructure -> Application Service -> Domain Service -> Domain Repository -> Domain Entities -> Domain Value Objects