[WIP] Implement initialisation pass of the schema to find all $id references #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because only it knows the correct context for the base URL.
|
I'd like to merge commit e5ea8ac into develop as the first part of this and then continue with the refactoring. Just to help break this thing into more understandable pieces. This first part replaces the use of strings for URLs in several places with an actual URL type. It also normalises all URLs to always have a fragment (even if empty). Schema loaders are now never given the fragment, as that can't be part of URL fetching anyway. |
This no longer passes even the basic tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The draft v7 test suite has been updated to check that this happens as laid in the spec. There are still problems in the spec, but we really do want to pass the test suite.