dcp: Restore UID/GID after setting with --uid/--gid #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofaaland
requested changes
Oct 7, 2024
src/dcp/dcp.c
Outdated
| if (setgroups(0, NULL) < 0) { | ||
| MFU_LOG(MFU_LOG_ERR, "Could not setgroups: %s", strerror(errno)); | ||
| mfu_finalize(); | ||
| MPI_Finalize(); | ||
| return 1; | ||
| } | ||
|
|
||
| /* record the original groups */ | ||
| getgroups(MAX_GIDS, &gids); |
There was a problem hiding this comment.
Please check this for failure and report it (e.g. errno==EINVAL means MAX_GIDS was too small), or dynamically get the size needed and allocate the buffer for the gids.
It was my bug, so I felt obligated! 😄 |
ofaaland
reviewed
Oct 8, 2024
|
Hi @bdevcich can you squash these commits and re-push? Thanks |
When `--uid` or `--gid` is used, MPI_Init() is called as the original user. The original uid/gid is not being restored prior to calling MPI_Finalize(), which leads to cleanup issues. Resolves hpc#585. Signed-off-by: Blake Devcich <[email protected]>
bdevcich
force-pushed
the
drop-egid-euid
branch
from
78e16e3 to
d56910b
Compare
|
@ofaaland done! |
|
@ofaaland can you merge? I don't have permission to do so. |
Odd, I thought I already had. I'll try again. |
|
@bdevcich there you go. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
--uidor--gidis used, MPI_Init() is called as the original user. The original uid/gid is not being restored prior to calling MPI_Finalize(), which leads to cleanup issues.Resolves #585.