-
Notifications
You must be signed in to change notification settings - Fork 64
feat: Add @observablehq/notebook-kit support #4439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add @observablehq/notebook-kit support #4439
Conversation
@jeclrsg ready for review... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for @observablehq/notebook-kit integration to the observablehq-compiler package. It introduces new compilation pathways and utilities to work with the notebook-kit runtime system.
Key changes:
- Adds @observablehq/notebook-kit as a dependency and integrates its runtime capabilities
- Implements new compiler functions to support notebook-kit format alongside existing Observable formats
- Adds comprehensive test coverage with sample HTML notebooks demonstrating the new functionality
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
vite.config.ts | Configures build system with npm/jsr import resolution and top-level await support |
tests/index-notebookkit.ts | Adds comprehensive test suite for notebook-kit integration with HTML, OMD, and OJS formats |
src/util.ts | Extends utilities with notebook-kit conversion functions and function constructor improvements |
src/compiler.ts | Adds compileKit function and overloaded compile methods for notebook-kit support |
src/index.ts | Exports new notebook-kit related functions |
package.json | Adds notebook-kit and related dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Gordon Smith <[email protected]>
...rebased and passing tests.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GordonSmith only thing I wanted to double-check about was that case in vite.config.ts for jquery ui. Would approve otherwise.
feat: Add @observablehq/notebook-kit support
Checklist:
Testing: