Skip to content

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Aug 21, 2025

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

@GordonSmith GordonSmith requested a review from Copilot August 21, 2025 15:15
Copilot

This comment was marked as outdated.

Copilot

This comment was marked as outdated.

Copilot

This comment was marked as outdated.

Copilot

This comment was marked as outdated.

@GordonSmith
Copy link
Member Author

@jeclrsg ready for review...

Copilot

This comment was marked as outdated.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for @observablehq/notebook-kit integration to the observablehq-compiler package. It introduces new compilation pathways and utilities to work with the notebook-kit runtime system.

Key changes:

  • Adds @observablehq/notebook-kit as a dependency and integrates its runtime capabilities
  • Implements new compiler functions to support notebook-kit format alongside existing Observable formats
  • Adds comprehensive test coverage with sample HTML notebooks demonstrating the new functionality

Reviewed Changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
vite.config.ts Configures build system with npm/jsr import resolution and top-level await support
tests/index-notebookkit.ts Adds comprehensive test suite for notebook-kit integration with HTML, OMD, and OJS formats
src/util.ts Extends utilities with notebook-kit conversion functions and function constructor improvements
src/compiler.ts Adds compileKit function and overloaded compile methods for notebook-kit support
src/index.ts Exports new notebook-kit related functions
package.json Adds notebook-kit and related dependencies

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@GordonSmith
Copy link
Member Author

...rebased and passing tests....

Copy link
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith only thing I wanted to double-check about was that case in vite.config.ts for jquery ui. Would approve otherwise.

@GordonSmith GordonSmith merged commit e78b158 into hpcc-systems:candidate-3.x.x Aug 26, 2025
1 check passed
GordonSmith added a commit that referenced this pull request Aug 26, 2025
feat: Add @observablehq/notebook-kit support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants