feat: Bump versions #318
feat: Bump versions #318
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: Gordon Smith <[email protected]>
GordonSmith
force-pushed
the
BUMP_VERSIONS
branch
from
b33b828 to
b19c6c7
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR bumps versions across various dependencies and tools in the project, including both C++ native libraries and JavaScript/Node.js packages.
- Updates core library versions including Graphviz (13.1.1 → 13.1.2) and Emscripten SDK (4.0.11 → 4.0.12)
- Upgrades JavaScript tooling dependencies like ESLint, TypeScript, and various build tools
- Updates vcpkg baseline and package configurations to support the new library versions
Reviewed Changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| vcpkg-overlays/graphviz/vcpkg.json | Updates Graphviz version from 13.1.1 to 13.1.2 |
| vcpkg-overlays/graphviz/portfile.cmake | Updates SHA512 hash for new Graphviz version |
| vcpkg-configuration.json | Updates vcpkg baseline to newer commit |
| tests/bundlers/package.json | Updates Rollup and Webpack versions |
| scripts/cpp-install-vcpkg.sh | Updates vcpkg build tools version |
| scripts/cpp-install-emsdk.sh | Updates Emscripten SDK version from 4.0.11 to 4.0.12 |
| packages/*/package.json | Updates @hpcc-js/esbuild-plugins across multiple packages |
| packages/graphviz/tests/graphviz.spec.ts | Updates expected version test for Graphviz |
| packages/duckdb/src/duckdb.ts | Fixes Blob constructor usage with Uint8Array wrapper |
| package.json | Updates multiple dev dependencies including ESLint, TypeScript, and documentation tools |
| README.md | Updates documented versions for Graphviz and Emscripten SDK |
| @@ -49,14 +49,14 @@ export class DuckDB { | |||
| */ | |||
| static load(): Promise<DuckDB> { | |||
| const workerUrl = URL.createObjectURL( | |||
| new Blob([loadWasmWorker()], { type: "text/javascript" }) | |||
| new Blob([new Uint8Array(loadWasmWorker())], { type: "text/javascript" }) | |||
There was a problem hiding this comment.
Creating a Uint8Array from what appears to be JavaScript code (loadWasmWorker()) is incorrect. JavaScript worker code should be passed as a string to the Blob constructor, not as a Uint8Array.
| new Blob([new Uint8Array(loadWasmWorker())], { type: "text/javascript" }) | |
| new Blob([loadWasmWorker()], { type: "text/javascript" }) |
Copilot uses AI. Check for mistakes.
| const wasmUrl = URL.createObjectURL( | ||
| new Blob([load()], { "type": "application/wasm" }) | ||
| new Blob([new Uint8Array(load())], { "type": "application/wasm" }) |
There was a problem hiding this comment.
While wrapping WASM data in Uint8Array may be correct if load() returns an array-like structure, this change should be verified to ensure load() doesn't already return a Uint8Array or ArrayBuffer that would make this wrapper redundant or incorrect.
Copilot uses AI. Check for mistakes.
No description provided.