CI Update default arg tests #1263
Conversation
| @@ -1,4 +1,4 @@ | |||
| calling: int main(int, char**) | |||
| 012 | |||
| a newer compiler | |||
| an older compiler | |||
There was a problem hiding this comment.
Is this intended? 14 is the most recent version of GCC released only a few months back.
There was a problem hiding this comment.
There was a problem hiding this comment.
It does smell like it. @hsutter do you confirm, should I fix it in this PR?
There was a problem hiding this comment.
This test does not test whether gcc-14 is modern but whether you can test its version at compile time.
There was a problem hiding this comment.
I agree, but it is still a bit strange to see a very recent compiler marked as old.
To me the name gcc_clang_msvc_min_versions suggest that if the actual version is equal to the value stored internally the version should be accepted.
jarzec
force-pushed
the
ci-update-def-arg-test
branch
from
354e011 to
bb433a2
Compare
| @@ -34,3 +34,6 @@ true | |||
| true | |||
| false | |||
| false | |||
|
|
|||
| Make sure views::take works: | |||
There was a problem hiding this comment.
Now that GCC 14 is considered newer compiler it is allowed to do this as well.
regression-tests/test-results/clang-18-c++20/pure2-bugfix-for-ufcs-arguments.cpp copy.execution
Show resolved
Hide resolved
...-tests/test-results/clang-18-c++23-libcpp/pure2-bugfix-for-ufcs-arguments.cpp copy.execution
Show resolved
Hide resolved
|
@hsutter If you agree with the outcome of the discussions this test update is ready to go. |
|
Thanks! |
As stated in the title.