fix compilation errors with exceptions disabled #1355
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, compiling with -fno-exceptions will not work because
cpp2util.h
uses try-catch and throw without checking if the macroCPP2_NO_EXCEPTIONS
is defined.I've done the following and now compiling with exceptions disabled works fine:
cpp2::string_util::string_to_int
function an implementation whenCPP2_NO_EXCEPTIONS
is setThrow
instead ofthrow
insidecpp2::range
constructor