patch for -Wshadow-field-in-constructor #260
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hypatia-of-sva <[email protected]>
|
Thanks for your pull request! It looks like this may be your first contribution to cppfront. Before I can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Please send me your email address (by private email is fine), and I can send you one. |
Repository owner
deleted a comment from
hypatia-of-sva
Feb 19, 2023
Repository owner
deleted a comment from
SebastianTroy
Feb 19, 2023
Repository owner
deleted a comment from
hypatia-of-sva
Feb 19, 2023
|
Thanks! I deleted the comments in this thread with/about the email address as it didn't seem you intended them to be visible here. I'll follow up in private email. |
|
Okay, then thats fine, I wasnt sure which address would be appropriate to send to. |
zaucy
pushed a commit
to zaucy/cppfront
that referenced
this pull request
Dec 5, 2023
Feature: Code like `f: (out x: _) = { x = 42; }` now works, and can work with any type that is constructible from the rhs (here `42`)... see the new regression test for an example
Step toward self-hosting: Start including `cpp2util.h` in cppfront itself... and add (and use) unconditional `final_action`/`finally`
Usability: nicer diagnostics for if/else that forgot the required `{` `}` around the body
Also: closes hsutter#260
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small patch that makes cpp2 code compile under -Wshadow, specifically -Wshadow-field-in-constructor. The only other remaining conflicts with clang's -Weverything (besides the obvious C++98 compatibilty options) are reserved identifieres with leading _ (which should be fine in a system level header) and -Wctad-maybe-unsupported, which says there should be a deduction guide for c_raii and fopen, which I would have to further look into how to implement