Skip to content

fix(cpp1): emit converting assignment from converting constructor #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(cpp1): emit converting assignment from converting constructor #474

wants to merge 1 commit into from

Conversation

JohelEGP
Copy link
Contributor

@JohelEGP JohelEGP commented May 30, 2023 •
edited
Loading

Resolves #468.

Testing output. 
100% tests passed, 0 tests failed out of 676

Total Test time (real) = 107.16 sec
Acknowledgements.

@JohelEGP

This comment was marked as resolved.

Sign in to view
@JohelEGP JohelEGP force-pushed the converting_assignment branch 4 times, most recently from 7408ca5 to 9c73d7d Compare May 31, 2023 21:42
@JohelEGP JohelEGP force-pushed the converting_assignment branch from 2dfc9a9 to 5a0144f Compare June 19, 2023 20:19
@hsutter
Copy link
Owner

hsutter commented Jul 9, 2023

Thanks! Per #468 discussion, I've applied a different fix in commit eac30d8 which fixes a bug that prevented you from opting out of the generated converting assignment operator. Now you can opt out by writing a private one yourself.

@hsutter hsutter closed this Jul 9, 2023
@JohelEGP JohelEGP deleted the converting_assignment branch July 9, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Converting assignment generated from non-converting constructor
2 participants
@JohelEGP @hsutter