Skip to content

fix(parse): recognize parameter named after contextual keyword #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(parse): recognize parameter named after contextual keyword #505

wants to merge 1 commit into from

Conversation

JohelEGP
Copy link
Contributor

@JohelEGP JohelEGP commented Jun 9, 2023 •
edited
Loading

Resolves #397.

Testing summary:

100% tests passed, 0 tests failed out of 686

Total Test time (real) = 107.58 sec

Acknowledgements:

@JohelEGP JohelEGP force-pushed the parameter_named_after_contextual_keyword branch from b716dcb to f9d9dee Compare July 11, 2023 01:08
@hsutter hsutter mentioned this pull request Aug 10, 2023
Closed
hsutter added a commit that referenced this pull request Aug 10, 2023
@hsutter
Diagnose missing parameter after a this-specifier or parameter-direct…
10ed7ff 
…ion, closes #397 and #505
@JohelEGP
Copy link
Contributor Author

Resolved by the commit above.

@JohelEGP JohelEGP closed this Aug 10, 2023
@JohelEGP JohelEGP deleted the parameter_named_after_contextual_keyword branch August 10, 2023 01:13
zaucy pushed a commit to zaucy/cppfront that referenced this pull request Dec 5, 2023
@hsutter @zaucy
Diagnose missing parameter after a this-specifier or parameter-direct…
4e2f7ad 
…ion, closes hsutter#397 and hsutter#505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Parameter named after contextual keyword is lost
1 participant
@JohelEGP