Skip to content

Adds CMake support #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

mordante
Copy link

@mordante mordante commented Oct 9, 2022

Adds a simple CMake script and makes the tests portable with both Windows and Linux support.

Adds a simple CMake script and makes the tests portable with both
Windows and Linux support.
@mordante
Copy link
Author

mordante commented Oct 9, 2022

Note there's some overlap with #21, but these tests Linux tests are closer to the batch tests. (I noticed you want to rework them @hsutter, but I needed something to test on Linux,)

@hsutter
Copy link
Owner

hsutter commented Oct 9, 2022

As with #4 and #15 and similar, for now I'd be happy to link to a sister project from the wiki.

If you make this a sister project, let me know the link and description I should use. Thanks!

@hsutter hsutter closed this Oct 9, 2022
@alexreinking
Copy link

This was already attempted in #15, which was reworked into modern-cmake/cppfront (and is mentioned in the wiki of this repository) and is a much more complete implementation.

@alexreinking
Copy link

There are a lot of problems with the implementation here, ranging from the misuse of CMAKE_BINARY_DIR to the overcomplicated configuration of the test runner script.

I encourage you to use the modern-cmake/cppfront repo, which is friendly to add_subdirectory and FetchContent, has find_package support, and a CTest-based test harness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants