Skip to content

Remove unnecessary compatibility shim for BytesIO #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Remove unnecessary compatibility shim for BytesIO #401

merged 1 commit into from
Oct 1, 2018

Conversation

jdufresne
Copy link
Contributor

io.BytesIO is available on all supported Pythons. Can simplify by assuming the import will succeed.

io.BytesIO is available on all supported Pythons. Can simplify by
assuming the import will succeed.
@jdufresne
Copy link
Contributor Author

The AppVeyor failures are unrelated to this changed and are fixed in #397.

Copy link
Member

@gsnedders gsnedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not supported from 2.6? I'm not sure we've ever supported < 2.6 and 3, so I dunno why that's even there. Oh well! Thanks for catching this.

@gsnedders gsnedders merged commit 0ba6628 into html5lib:master Oct 1, 2018
@jdufresne jdufresne deleted the bytesio branch February 26, 2020 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants