Removed obligatory async-std dep #168
Conversation
Cargo.toml
Outdated
| @@ -39,6 +49,7 @@ url = "2.1.1" | |||
| serde_json = "1.0.51" | |||
| serde = { version = "1.0.106", features = ["derive"] } | |||
| serde_urlencoded = "0.6.1" | |||
| piper = "*" | |||
| cookie-secure = ["cookie/secure"] | ||
|
|
||
| [dependencies.futures-io] |
There was a problem hiding this comment.
Instead of using futures and piper I would suggest using async-std with the default features, especially the runtime turned off. This way nothing changes in terms of code, but you are not forced to pull in the async-std runtime anymore, just the tooling like channels etc.
There was a problem hiding this comment.
with async-rs/async-std#806 this
async-std = { version = "1.6", default-features = false, features = ["unstable"] }should not pull in any runtime
|
Yeah, piper can be changed to 'async-channel'.
ср, 3 июн. 2020 г. в 19:21, Friedel Ziegelmayer <[email protected]>:
… ***@***.**** commented on this pull request.
------------------------------
In Cargo.toml
<#168 (comment)>:
> cookie-secure = ["cookie/secure"]
+[dependencies.futures-io]
Instead of using futures and piper I would suggest using async-std with
the default features, especially the runtime turned off. This way nothing
changes in terms of code, but you are not forced to pull in the async-std
runtime anymore, just the tooling like channels etc.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#168 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACPXFNZL74F24QYEZ5GNVLTRUZZ6ZANCNFSM4NPZ42DQ>
.
--
С Уважением,
Сергей
|
There was a problem hiding this comment.
Hi @serzhiio thanks for opening this PR. I've looked at this and agree with @dignifiedquire. Configuring async-std to not include the runtime indeed seems like a more sustainable solution.
|
It's been a month since the last activity on this PR, with a fair few changes requested. We may want to switch |
Body::from_file() maybe is not working