Skip to content

Raise warning instead of error for block offloading with streams #11425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

a-r-r-o-w
Copy link
Member

Addresses: #11375 (comment)

Note that you could use num_blocks_per_group > 1 when using streams (the previous implementation allowed that, but only if the initialization order of blocks was the same as invocation order), but typically the computation of a single block completes before the next block finishes onloading, so setting it to 1 and only supporting that case seems reasonable.

@a-r-r-o-w a-r-r-o-w requested a review from DN6 April 27, 2025 05:21
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants