Raise warning instead of error for block offloading with streams #11425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #11375 (comment)
Note that you could use
num_blocks_per_group > 1
when using streams (the previous implementation allowed that, but only if the initialization order of blocks was the same as invocation order), but typically the computation of a single block completes before the next block finishes onloading, so setting it to1
and only supporting that case seems reasonable.