[lora] adapt new LoRA config injection method #11999
Open
+33
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
commented
Jul 28, 2025
setup.py
Outdated
| @@ -117,6 +117,7 @@ | |||
| "numpy", | |||
| "parameterized", | |||
| "peft>=0.15.0", | |||
| # "peft>=0.16.1", | |||
There was a problem hiding this comment.
To be changed when peft has the release.
This was referenced Jul 28, 2025
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Now that PEFT 0.17.0 is out, we should be good to review this PR. Gentle ping @BenjaminBossan |
BenjaminBossan
approved these changes
Aug 6, 2025
|
@DN6 could you give this a check please? This solves some existing issues around complicated logic of deriving some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #11874
Relies on huggingface/peft#2637
Supercedes #11911
TODO: Run some integration tests before merging.
Edit: Have run the integration tests for SDXL and Flux and they work.