Migrate lora pipeline tests to use pytest
#12426
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
commented
Oct 3, 2025
| def test_simple_inference_with_text_denoiser_lora_unfused(self): | ||
| super().test_simple_inference_with_text_denoiser_lora_unfused(expected_atol=9e-3) | ||
|
|
||
| def test_simple_inference_save_pretrained(self): |
There was a problem hiding this comment.
It's not testing any LoRA-related stuff. So, let's remove.
sayakpaul
changed the title
pytestpytest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrates the LoRA pipeline tests (
tests/lora/) to purepytestbecause it has multiple advantages.Summary of changes
pytestfixtures wherever possible. This applies totmpdirname,base_pipe_output, etc. This also helps in reducing LoC.self.assert*methods with simplerasserts.pytestfixtures as well.Will let the CI decide if this is good to go. Will also run the integration tests, meanwhile and fix anything that comes on the way.
Edit: Ran the integration tests and they're good to go :)