Skip to content

♻️ [Tasks] Use snake_case for parameters (+ misc format fixes) #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 9, 2024
Merged

♻️ [Tasks] Use snake_case for parameters (+ misc format fixes) #470

merged 6 commits into from
Feb 9, 2024

Conversation

SBrandeis
Copy link
Contributor

@SBrandeis SBrandeis commented Feb 7, 2024 •
edited
Loading

TL.DR

  • Use snake_case for parameters in the JSON schema
  • Some misc schema fixes:
    • Some output types were array where they should be objects
    • Fix a typo in 'description' preventing the JSDoc from being generated
    • Use the factorized classification output type for audio_classification task as well

@SBrandeis SBrandeis requested a review from julien-c February 7, 2024 13:36
@SBrandeis SBrandeis marked this pull request as ready for review February 7, 2024 13:36
@SBrandeis SBrandeis mentioned this pull request Feb 7, 2024
Open
11 tasks
julien-c
julien-c reviewed Feb 8, 2024
View reviewed changes
Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm a noob but why don't the TS types' parameters change when the schema properties' casing changes?

@SBrandeis
Copy link
Contributor Author

todo: don't convert params of generated types to camelcase

julien-c
julien-c reviewed Feb 8, 2024
View reviewed changes
Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed let's generate snake_case TS interfaces too for consistency (even if a bit ugly) ?

@SBrandeis SBrandeis merged commit 839c1ce into main Feb 9, 2024
@SBrandeis SBrandeis deleted the snake_case_specs branch February 9, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-c julien-c julien-c approved these changes

@coyotte508 coyotte508 coyotte508 approved these changes

@osanseviero osanseviero Awaiting requested review from osanseviero

@gary149 gary149 Awaiting requested review from gary149 gary149 is a code owner

@Wauplin Wauplin Awaiting requested review from Wauplin Wauplin is a code owner

@Narsil Narsil Awaiting requested review from Narsil

@philschmid philschmid Awaiting requested review from philschmid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SBrandeis @julien-c @coyotte508