Update Dockerfile to install curl #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Install curl so we are able to make health checks
|
I've just ran into this issue myself, wondering why all containers are unhealthy despite running and serving... My code for healthcheck is: Can you please add |
4 tasks
MasakiMu319
pushed a commit
to MasakiMu319/text-embeddings-inference
that referenced
this pull request
Nov 27, 2024
aagnone3
pushed a commit
to StratisLLC/hf-text-embeddings-inference
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The base image doesn't have curl or wget installed, so we cannot do health checks when this is deployed as a service (for example, in AWS ECS, which is my use case).
I propose installing
curlto be able to make container health checks like:curl -f http://localhost:8080/health || exit 1.Thanks!
Who can review?
@OlivierDehaene