Skip to content

Conversation

haixiw
Copy link
Contributor

@haixiw haixiw commented May 29, 2024

What does this PR do?

Fix the issue that compute_cap is not avaliable from nvidia-smi --query-gpu=compute_cap --format=csv | sed -n '2p' | sed 's/\.//g' when the CUDA driver version is old.

  1. add cuda compate script to dynamically switch the use of the CUDA Compatibility Package based on the detected Nvidia driver version on the deployed host . https://docs.aws.amazon.com/sagemaker/latest/dg/inference-gpu-drivers.html#collapsible-cuda-compat
  2. create a mapping from GPU name to compute_cap based on the current avaliable instances from AWS hosting.

Fixes # (issue) huggingface/candle#733

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Contributor

@OlivierDehaene OlivierDehaene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this fix!

@OlivierDehaene OlivierDehaene merged commit 96ed3cd into huggingface:main May 30, 2024
MasakiMu319 pushed a commit to MasakiMu319/text-embeddings-inference that referenced this pull request Nov 27, 2024
aagnone3 pushed a commit to StratisLLC/hf-text-embeddings-inference that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants