Skip to content

Add intel based images to the CI #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Add intel based images to the CI #518

merged 1 commit into from
Mar 25, 2025

Conversation

baptistecolle
Copy link
Collaborator

What does this PR do?

This PR add Intel based images to the CI

The new images will be available at

ghcr.io/huggingface/text-embeddings-inference:cpu-ipex-sha-<SHA_COMMIT>
ghcr.io/huggingface/text-embeddings-inference:xpu-ipex-sha-<SHA_COMMIT>
ghcr.io/huggingface/text-embeddings-inference:hpu-sha-<SHA_COMMIT>

@baptistecolle
Copy link
Collaborator Author

baptistecolle commented Mar 20, 2025

Unfortunately, I’m unable to pull and test the image from the PR due to the following condition in the workflow:

push: ${{ github.event_name != 'pull_request' }}

(See build.yaml#L126).

Ideally, we should align with TGI’s workflow for image building and set up a staging registry to allow testing CI-built images. However, I’ll leave this as a future improvement.

In the meantime, I believe this can be merged, as the images have been built and tested locally. Once the PR is merged, we’ll be able to test the latest images for cpu-ipex, xpu-ipex, and hpu-sha, and apply a patch if any issues arise. While this isn’t ideal, it seems to be the best approach without a staging environment.

@baptistecolle
Copy link
Collaborator Author

baptistecolle commented Mar 20, 2025

FYI: @kaixuanliu

Continuation of #517 by an external contributor (intel)

@baptistecolle baptistecolle requested a review from Narsil March 20, 2025 10:30
@baptistecolle baptistecolle marked this pull request as ready for review March 20, 2025 10:33
@Narsil Narsil merged commit 2fded50 into main Mar 25, 2025
13 checks passed
@Narsil Narsil deleted the ci/add-intel-based-images branch March 25, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants