Skip to content

Use --hf-token instead of --hf-api-token #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2025
Merged

Conversation

alvarobartt
Copy link
Member

@alvarobartt alvarobartt commented Mar 26, 2025

What does this PR do?

This PR deprecates the --hf-api-token argument in favor of --hf-token, to be compliant with the standard naming for the Hugging Face token, specially when provided via environment variable as HF_TOKEN, but also to be aligned with the text-generation-inference counterpart.

image

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline, Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@Narsil or @McPatate

Aligned with the `text-generation-inference` counterpart
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@alvarobartt alvarobartt marked this pull request as ready for review March 26, 2025 09:19
Copy link
Collaborator

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Narsil Narsil merged commit 1db97c2 into main Mar 26, 2025
14 checks passed
@Narsil Narsil deleted the deprecate-hf-api-token branch March 26, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants