Skip to content

change HPU warmup logic: seq length should be with exponential growth #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 26, 2025
Merged

change HPU warmup logic: seq length should be with exponential growth #659

merged 3 commits into from
Jun 26, 2025

Conversation

kaixuanliu
Copy link
Contributor

No description provided.

@kaixuanliu
Copy link
Contributor Author

As model input length increases greatly (like Qwen3), we need to change HPU warmup lengths with exponential growth. @regisss pls help review. Thx

regisss
regisss approved these changes Jun 26, 2025
View reviewed changes
Copy link
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@regisss regisss merged commit 2adbd12 into huggingface:main Jun 26, 2025
@regisss
Copy link
Collaborator

regisss commented Jun 26, 2025

cc @Narsil: in backends/src/lib.rs, only the warmup_hpu method is changed

@BrewTestBot BrewTestBot mentioned this pull request Jun 30, 2025
Merged
@BrewTestBot BrewTestBot mentioned this pull request Aug 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regisss regisss regisss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaixuanliu @regisss