Skip to content

Fix: handle None defaults safely in SegformerMixFFN #40721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix: handle None defaults safely in SegformerMixFFN #40721

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22e894d
Fix: handle None defaults safely in SegformerMixFFN
JawadAliAI Sep 5, 2025
89e0512
Merge branch 'main' into fix-segformer
JawadAliAI Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/transformers/models/segformer/modeling_segformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,13 +277,21 @@ def forward(self, hidden_states, height, width):
class SegformerMixFFN(nn.Module):
def __init__(self, config, in_features, hidden_features=None, out_features=None):
super().__init__()
out_features = out_features or in_features

# ✅ Explicitly handle None, avoid overriding falsy values like 0
if out_features is None:
out_features = in_features
if hidden_features is None:
hidden_features = in_features

self.dense1 = nn.Linear(in_features, hidden_features)
self.dwconv = SegformerDWConv(hidden_features)

if isinstance(config.hidden_act, str):
self.intermediate_act_fn = ACT2FN[config.hidden_act]
else:
self.intermediate_act_fn = config.hidden_act

self.dense2 = nn.Linear(hidden_features, out_features)
self.dropout = nn.Dropout(config.hidden_dropout_prob)

Expand Down