Skip to content

Conversation

liangel-02
Copy link

@liangel-02 liangel-02 commented Sep 9, 2025

Summary

Renaming get_state_dict() method in hf_quantizer to get_state_dict_and_metadata() and updating functionality to return metadata along with state_dict.

This reduces confusion related to enabling torchao safetensor support built out in this PR.

Test Plan

python -m pytest ./tests/quantization

@liangel-02 liangel-02 force-pushed the rename_fn branch 2 times, most recently from ee90575 to b171b2d Compare September 9, 2025 19:12
@liangel-02 liangel-02 marked this pull request as ready for review September 9, 2025 19:15
@liangel-02 liangel-02 force-pushed the rename_fn branch 2 times, most recently from b15033e to 9e5d89e Compare September 9, 2025 19:18
@liangel-02 liangel-02 marked this pull request as draft September 9, 2025 19:25
Copy link
Contributor

github-actions bot commented Sep 9, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: mxfp4

@liangel-02 liangel-02 marked this pull request as ready for review September 9, 2025 19:51
@Rocketknight1
Copy link
Member

cc @SunMarc

@jerryzh168
Copy link
Contributor

cc @MekkCyber @SunMarc please take a look again

Copy link
Contributor

@MekkCyber MekkCyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🤗 LGTM

@liangel-02
Copy link
Author

@MekkCyber do you mind merging this? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants