Support reverse proxies that terminate HTTPS #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bamboo has a fair number of absolute URLs in it, not least redirects during setup. If you have a reverse proxy (such as Amazon's ELB) in front of a Bamboo server docker instance (such as on Amazon's ECS) without this patch, Bamboo will redirect you from HTTPS to HTTP constantly making the application unusable.
This patch allows you to specify the BAMBOO_SCHEME env var to either http or https (defaulting to https). We use xmlstarlet to set the appropriate connector attributes in the Tomcat server.xml file.