Make some functions less-generic to reduce binary bloat #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
reviewed
Dec 22, 2020
|
Testing with and without this on hyper's http_proxy example which triggers two instantiatiations of decode_frame, etc. Gives a ~10% reduction in emitted LLVM IR 553979 / 610618 = 0.90724315366 |
Marwes
force-pushed
the
minimize
branch
2 times, most recently
from
4b024aa to
46b285d
Compare
|
Any chance of this getting merged? |
Marwes
force-pushed
the
minimize
branch
3 times, most recently
from
f443750 to
6547af7
Compare
added 11 commits
February 17, 2021 14:31
Should cut out another 23 KiB (since I see it duplicated)
The `P: Peer` parameter is rarely used and there is already a mechanism for using it dynamically.
seanmonstar
reviewed
Feb 18, 2021
seanmonstar
approved these changes
Feb 18, 2021
BenxiangGe
pushed a commit
to BenxiangGe/h2
that referenced
this pull request
Jul 26, 2021
* refactor: Extract FramedWrite::buffer to a less generic function Should cut out another 23 KiB (since I see it duplicated) * refactor: Extract some duplicated code to a function * refactor: Extract part of flush into a less generic function * refactor: Extract a less generic part of connection * refactor: Factor out a less generic part of Connection::poll2 * refactor: Extract a non-generic part of handshake2 * refactor: Don't duplicate Streams code on Peer (-3.5%) The `P: Peer` parameter is rarely used and there is already a mechanism for using it dynamically. * refactor: Make recv_frame less generic (-2.3%) * Move out part of Connection::poll * refactor: Extract parts of Connection * refactor: Extract a non-generic part of reclaim_frame * comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't see #484 until after the fact so I can remove that commit if desired, it is arguably a cleaner separation though since it extracts a separate and private struct instead of passing multiple parameters.