Skip to content

Don't stop parsing after invalid elements in Access-Control-Allow-Headers #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −6
Open

Don't stop parsing after invalid elements in Access-Control-Allow-Headers #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/common/access_control_allow_headers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use http::{HeaderName, HeaderValue};
use crate::util::FlatCsv;

/// `Access-Control-Allow-Headers` header, part of
/// [CORS](http://www.w3.org/TR/cors/#access-control-allow-headers-response-header)
/// [CORS](https://fetch.spec.whatwg.org/#access-control-allow-headers-response-header)
///
/// The `Access-Control-Allow-Headers` header indicates, as part of the
/// response to a preflight request, which header field names can be used
Expand Down Expand Up @@ -42,11 +42,7 @@ derive_header! {
impl AccessControlAllowHeaders {
/// Returns an iterator over `HeaderName`s contained within.
pub fn iter(&self) -> impl Iterator<Item = HeaderName> + '_ {
self.0
.iter()
.map(|s| s.parse().ok())
.take_while(|val| val.is_some())
.flatten()
self.0.iter().filter_map(|s| s.parse().ok())
}
}

Expand Down