Hyper client discards query string when making requests

[gtolle]

Hi all,

Found an issue while using Hyper's HTTP client.

When starting the request, Hyper calls rust-url's serialize_path function to generate the first header line, but serialize_path discards the query string from the URL. This breaks any GET request that depends on query parameters.

I sent a new pull request to rust-url that introduces a serialize_path_with_query method specifically so that Hyper can use it.

servo/rust-url#38

If serialize_path_with_query gets merged into rust-url, I'm happy to create a pull request that updates Hyper to match.

[seanmonstar]

If that gets merged into a rust-url, I'd be happy to use it. Until then, I'll just submit a fix to unblock you (or anyone else) right now.

[gtolle]

Awesome! Thanks much.

[gtolle]

Also, I thought I'd share the project I'm working on - would love to hear your feedback.

It's a high-level REST API client in Rust, inspired by Ruby's rest-client. I'm going for the smallest amount of code to make the most common types of REST API calls. It depends heavily on Hyper, of course.

https://github.com/gtolle/rest_client

It does work, but it's my first piece of Rust code and there are probably tons of things I could be doing better.

[adwhit]

This issue has resurfaced, possibly due to the changes in rust-url 1.0.

servo/rust-url#176

serialize_without_fragment is now &url[..Position::AfterQuery]

[matt2xu]

Yep, I just witnessed the same thing. I'm under the impression that the problem is there:
https://github.com/hyperium/hyper/blob/master/src/client/mod.rs#L303

There is no mention of query anymore (or fragment for that matter). Maybe a simpler way would be to call url.set_host(None) to remove the host and port, and then url.into_string(), so everything else (path, query, fragment) is preserved.

[seanmonstar]

I've fixed this on master again, sorry for the bugs!

[matt2xu]

"again" ah I know that feeling... Thanks for fixing this!