fix(server): remove Sync + Send + 'static trait bound #1331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove unnecessary for tokio-based async server thait bounds according to Issue hyperium#1327 BREAKING CHANGE: server NewService and Http API
mersinvald
changed the title
mersinvald
changed the title
|
Since this change relaxes the thait requirements should it be concidered as breaking? |
|
Didn't notice the existing PR on the same reason: #1275 |
|
Hey there! Thanks for submitting this! As you noticed, there was also #1275, and some discussion happened in there around why these bounds existed. I've since finally merged that PR. This should be in 0.11.3 soon! |
|
@seanmonstar that's awesome news! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary for tokio-based async server thait bounds according to Issue #1327
BREAKING CHANGE: server NewService and Http API
Thanks to @LooMaclin for writing this patch in the first place.