refac: use tokio's TcpSocket for more sockopts #2335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still need `socket2` specifically for TCP keepalive, but we may just end up removing that soon? Signed-off-by: Eliza Weisman <[email protected]>
hawkw
commented
Nov 18, 2020
Comment on lines
+590
to
+595
| if let Some(dur) = config.keep_alive_timeout { | ||
| socket | ||
| .set_keepalive(Some(dur)) | ||
| .map_err(ConnectError::m("tcp set_keepalive error"))?; | ||
| } | ||
|
|
There was a problem hiding this comment.
@seanmonstar should I just remove keepalive from the hyper API instead? That way, we could just drop the socket2 dep entirely.
There was a problem hiding this comment.
Humm.... maybe. It is a confusing property, but people do enable it to notice when a connection has died... 🤷
There was a problem hiding this comment.
Yeah...it's looking like Tokio will probably not add support for more sophisticated configuration (e.g. keepalive retries/probe interval/etc). But it would be nice if it at least had an API for enabling/disabling keepalive and maybe setting the initial timeout before keepalive probes are sent, which should be more portable.
BenxiangGe
pushed a commit
to BenxiangGe/hyper
that referenced
this pull request
Jul 26, 2021
) Signed-off-by: Eliza Weisman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still need
socket2specifically for TCP keepalive, but we may justend up removing that soon?
Signed-off-by: Eliza Weisman [email protected]